Don't use js.Map in ClassValue when targeting pure Wasm#1
Open
lostflydev wants to merge 1 commit intoscala-wasmfrom
Open
Don't use js.Map in ClassValue when targeting pure Wasm#1lostflydev wants to merge 1 commit intoscala-wasmfrom
lostflydev wants to merge 1 commit intoscala-wasmfrom
Conversation
lostflydev
force-pushed
the
fix/147-classvalue-linktime
branch
from
3f9e613 to
d78dc6b
Compare
lostflydev
pushed a commit
that referenced
this pull request
Mar 10, 2026
- Remove top-level vals with JS types (RegExp, js.Function1) that caused linker errors in pure Wasm mode; inline them into linkTimeIf JS branches - Convert quoteStr from val to def so JS function is created lazily - Restore ClassValueTest exclusion (belongs to separate PR #1)
Add LinkingInfo.targetPureWasm guards to ClassValue so the linker can dead-code-eliminate the js.Map branch for pure Wasm builds, always using HashMap instead. Enable ClassValueTest in pure Wasm test suite. Fixes scala-wasm#147
lostflydev
force-pushed
the
fix/147-classvalue-linktime
branch
from
d78dc6b to
702d48e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add LinkingInfo.targetPureWasm guards to ClassValue so the linker can dead-code-eliminate the js.Map branch for pure Wasm builds, always using HashMap instead.
Fixes scala-wasm#147