Open
Conversation
00ab0b9 to
9ad1162
Compare
Add linkTimeIf branches for all JS-dependent operations in URI: - URI parsing: js.RegExp.exec() → java.util.regex.Pattern - Path normalization: js.Array + .join() → Scala Array + StringBuilder - IPv6 detection: js.RegExp.test() → java.util.regex.Pattern - Quoting (5 functions): jsReplace(regex, callback) → quoteWithPattern() - UTF-8 percent-encoding: pure Scala via StandardCharsets.UTF_8 Remove top-level vals with JS types (RegExp, js.Function1) to avoid linker errors; inline them into linkTimeIf JS branches instead. Unblock URITest in pure Wasm test suite. Add 6 new tests covering multi-component quoting, IPv6, normalize edge cases, and non-ASCII.
6f7a29d to
915b509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make java.net.URI fully compatible with the pure Wasm backend by providing linkTimeIf branches for all JS-dependent operations.
Closes scala-wasm#153
Changes