Conversation
|
Marking as draft due to test failures: |
|
Only 1 test failure left after commit 99803d6: |
|
fixed in emnapi 1.9.1 |
|
@kleisauke Thanks for investigating this and @toyobayashi thanks for the quick fix. The remaining sharp test failure appears to relate to the new I think the WebAssembly equivalent is the |
99803d6 to
b2dc727
Compare
|
From a quick look, an I'll investigate this later, but in the meantime I'm marking this PR as ready. |
|
@kleisauke I fixed the test failure via commit 3879c9a (this was also affecting Electron). |
Bump emnapi to 1.9.1 for compatibility with Emscripten 5.0.3, see:
emscripten-core/emscripten@3051725
/cc @toyobayashi FYI.