Skip to content

[I2C, sw] Move the write to CTRL.ENABLEHOST out of i2c_init #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-velay merged 1 commit into from
May 5, 2026
Merged

[I2C, sw] Move the write to CTRL.ENABLEHOST out of i2c_init #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sw/device/lib/hal/i2c.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ void i2c_init(i2c_t i2c)
(rnd_up_div(250, SYSCLK_NS) << I2C_TIMING3_TSU_DAT));
DEV_WRITE(i2c + I2C_TIMING4_REG, (rnd_up_div(4700, SYSCLK_NS) << I2C_TIMING4_T_BUF) |
(rnd_up_div(4000, SYSCLK_NS) << I2C_TIMING4_TSU_STO));

// -- Configure IP for Controller mode --
DEV_WRITE(i2c + I2C_CTRL_REG, (1u << I2C_CTRL_ENABLEHOST));
}

bool i2c_write_byte(i2c_t i2c, uint8_t addr, uint8_t data)
Expand Down
3 changes: 3 additions & 0 deletions sw/device/tests/i2c/smoketest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,8 @@ bool test_main()
{
i2c_t i2c = mocha_system_i2c();
i2c_init(i2c);

// -- Configure IP for Controller mode --
DEV_WRITE(i2c + I2C_CTRL_REG, (1u << I2C_CTRL_ENABLEHOST));
return as6212_test(i2c);
}