Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a "get next line" function (ft_gnl) to the libft library for reading lines from file descriptors, and renames parameters in list manipulation functions for better clarity.
Changes:
- Adds ft_gnl function implementation with supporting helper functions for reading lines from file descriptors
- Renames parameter 'new' to 'new_node' in ft_lstadd_front and ft_lstadd_back functions for better clarity
- Improves .gitignore file with better organization and additional patterns
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ft_gnl.c | New file implementing get-next-line functionality with buffer management and line extraction |
| src/ft_lstadd_front.c | Renames parameter from 'new' to 'new_node' for clarity |
| src/ft_lstadd_back.c | Renames parameter from 'new' to 'new_node' for clarity |
| includes/libft.h | Adds BUFFER_SIZE definition, updates function declarations, and adds ft_gnl prototype |
| Makefile | Adds ft_gnl.c to the source files list |
| .gitignore | Fixes malformed pattern and adds comprehensive ignore patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
[WIP] WIP: Address feedback on Add ft_gnl function pull request
3 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.