Fix static_libraries swallowing sequence of -framework flags#480
Merged
lu-zero merged 1 commit intolu-zero:masterfrom Aug 3, 2025
Merged
Conversation
amyspark
force-pushed
the
fix-missing-framework-flags-macos
branch
from
2608bf8 to
95a99d9
Compare
lu-zero
approved these changes
Aug 3, 2025
Owner
lu-zero
left a comment
lu-zero
left a comment
There was a problem hiding this comment.
Please update the tests accordingly :)
amyspark
force-pushed
the
fix-missing-framework-flags-macos
branch
from
95a99d9 to
f61ccbd
Compare
lu-zero
approved these changes
Aug 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @lu-zero ,
This MR fixes a mishap I found when testing the static version of GStreamer's Rust plugins: the code of
static_librarieswas monching-frameworkflags, which are unfortunately compound (followed by spaces instead of the-Wl,-frameworkform).Removing the
uniq()is sufficient, for a more optimized version I'll have to implement the deduplication in #470 .