Ifdef comp kernelverion #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That would be OK, but with the work on #311, it’s not very useful; moreover, it would induce merge conflicts when acompress gets done. |
lneto
reviewed
Aug 4, 2025
lib/luacrypto_comp.c
Outdated
| #if (LINUX_VERSION_CODE >= KERNEL_VERSION(6, 15, 0)) | ||
| #warning "crypto_comp API removed in Linux ≥6.15, skip COMP module" | ||
| #else | ||
|
|
lneto
reviewed
Aug 4, 2025
lib/luacrypto_comp.c
Outdated
| #include "luacrypto.h" | ||
|
|
||
| #if (LINUX_VERSION_CODE >= KERNEL_VERSION(6, 15, 0)) | ||
| #warning "crypto_comp API removed in Linux ≥6.15, skip COMP module" |
Contributor
There was a problem hiding this comment.
Suggested change
| #warning "crypto_comp API removed in Linux ≥6.15, skip COMP module" | |
| #warning "crypto_comp API was removed in Linux 6.15, skip COMP module" |
qrsikno2
force-pushed
the
ifdef_comp_kernelverion
branch
from
41eece5 to
96fa4f6
Compare
Contributor
it's just a temporary fix.. you can remove it completely on acompress branch.. if it's alright to you, I would merge it.. |
jperon
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
luacrypto_comp.cfile to ensure compatibility with different Linux kernel versions. The changes introduce conditional compilation to handle the deprecation of thecrypto_compAPI in Linux kernel version 6.15 and later.Compatibility updates for Linux kernel versions:
LINUX_VERSION_CODEto conditionally include thecrypto_compmodule only for kernels below version 6.15.crypto_compAPI is removed in Linux kernel versions 6.15 and above.Code maintenance:
<linux/version.h>to access theLINUX_VERSION_CODEmacro for kernel version checks.