add cpuexporter example #327
Open
+189
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lneto
force-pushed
the
lneto_unixsock
branch
3 times, most recently
from
ab72360 to
6bfe199
Compare
endersonmaia
force-pushed
the
endersonmaia_cpuexporter
branch
from
eef073b to
dc9abc9
Compare
lneto
reviewed
Nov 26, 2025
endersonmaia
force-pushed
the
endersonmaia_cpuexporter
branch
from
7fc2b58 to
88999fd
Compare
lneto
reviewed
Nov 27, 2025
endersonmaia
force-pushed
the
endersonmaia_cpuexporter
branch
from
26dbd1a to
830856a
Compare
lneto
reviewed
Nov 28, 2025
lneto
reviewed
Nov 29, 2025
lneto
reviewed
Nov 29, 2025
lneto
reviewed
Nov 29, 2025
lneto
reviewed
Nov 29, 2025
lneto
reviewed
Nov 29, 2025
lneto
reviewed
Nov 29, 2025
| local int_part = (value * 100) // total | ||
| local remainder = (value * 100) % total | ||
| local frac_high = (remainder * 100000000) // total | ||
| local remainder2 = (remainder * 100000000) % total |
Contributor
Author
There was a problem hiding this comment.
So I don't overflow 64bit integer and get a 16 decimals precision, I split the operation in two parts (high, low).
Contributor
There was a problem hiding this comment.
wouldn't you have enough precision using difftime?
lneto
reviewed
Nov 29, 2025
lneto
reviewed
Nov 29, 2025
Comment on lines
+30
to
+32
| local frac_high = (remainder * 100000000) // total | ||
| local remainder2 = (remainder * 100000000) % total | ||
| local frac_low = (remainder2 * 100000000) // total |
Contributor
There was a problem hiding this comment.
btw, it's not clear to me why we need to do this twice.. I would move the common pattern to a function anyway..
endersonmaia
force-pushed
the
endersonmaia_cpuexporter
branch
from
4569e43 to
7933e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basing on top of lneto_unixsock branch since I need it for longer filename.
I'm still planning to test it a little more comparing with other cpu collectors like telegraf and fluent-bit to make sure my measurements are correct.
I'm asking for review anyway since I need feedback on code quality and style, since I'm not Lua fluent yet.