Add senddata(luadata) & receivedata #330

Physic69 · 2025-12-09T20:24:53Z

add senddata, receivedata methods that operate directly on luadata buffer memory without Lua string copies.

lib/luasocket.c

lib/luadata.h

lib/luasocket.c

lib/luadata.h

lneto · 2025-12-15T11:22:04Z

lib/luadata.h

+	return (void *)(data->ptr + offset);
+}
+
+static inline void *luadata_checkrange(lua_State *L, int idata, int ioffset, int ilen, size_t *len_out)


I think we should pass just one index on the stack and assume them sequential.. like a CFunction..

lneto · 2025-12-15T11:23:38Z

lib/luadata.c

 module_exit(luadata_exit);
 MODULE_LICENSE("Dual MIT/GPL");
 MODULE_AUTHOR("Lourival Vieira Neto <lourival.neto@ring-0.io>");
-


lneto · 2025-12-15T11:25:54Z

lib/luadata.h

+	return (void *)(data->ptr + offset);
+}
+
+static inline void *luadata_checkrange(lua_State *L, int idata, int ioffset, int ilen, size_t *len_out)


I'm not fond of calling this function checkrange because it's too similar to checkbounds.. I would call it something like checkpointer (if we can't figure a better name)

getrange..How does it sound?

I think it should be check* to be clear it can raise an error and validate the args..

checkbuffer will do as well.. I think.. couldn't figure anything better.. heh

checkbuffer works for me. Sounds good 👍

lneto · 2025-12-15T11:26:55Z

lib/luasocket.c

+		vec.iov_base = (void *)luaL_buffinitsize(L, &B, len);
+	}
+	else {
+		data = luadata_check(L, 2);


you don't need this line anymore, right?

lneto · 2025-12-15T11:29:59Z

lib/luadata.h

+	return (void *)(data->ptr + offset);
+}
+
+static inline void *luadata_checkrange(lua_State *L, int idata, int ioffset, int ilen, size_t *len_out)


I don't think we need this need to be an inline.. I would have a regular function and export its prototype here, keeping the struct and checkbounds on the .c file

lneto · 2025-12-15T12:14:13Z

lib/luasocket.c


-	vec.iov_base = (void *)luaL_buffinitsize(L, &B, len);
-	vec.iov_len = len;
+	if (t2 != LUA_TUSERDATA && t2 != LUA_TLIGHTUSERDATA) {


that's weird.. why that?

will fix it, i thought( if not data) use string, else data. will make it similar like send function

but why checking for light userdata? I would just use the same pattern you used on send() indeed..

then, you can use type the type as a flag to take the decision later on to pushbuffer

lneto · 2025-12-15T12:15:35Z

lib/luasocket.c

+	flags = luaL_optinteger(L, ixopt, 0);
+    from = lua_toboolean(L, ixopt + 1);


as we are using C99, let's declare these vars in-here..

.. removing their declaration from the beginning of the function block

I thought we were following C89, so i made the early declerations. Will fix it up

lneto · 2025-12-23T21:40:40Z

lib/luadata.h

 #define	LUADATA_OPT_FREE	0x02
 #define	LUADATA_OPT_KEEP  	0x80

+


Suggested change

please review your patch regarding things like this..

Physic69 force-pushed the comeback branch 3 times, most recently from 08d3ffd to 1cb07fa Compare December 11, 2025 19:20

lneto reviewed Dec 11, 2025

View reviewed changes