Draft
Conversation
Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add configuration to restrict redirect hosts in login flow
Restrict redirect hosts in login flow
Mar 16, 2026
jeroenrinzema
requested changes
Mar 16, 2026
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/json" |
Contributor
There was a problem hiding this comment.
please use internal/http/json instead.
Contributor
Author
There was a problem hiding this comment.
Done in c86e4df — replaced encoding/json with internal/http/json.
Co-authored-by: jeroenrinzema <3440116+jeroenrinzema@users.noreply.github.com>
f1f4c61 to
734e288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
redirectparameter in the auth callback was never validated, allowing redirects to arbitrary external hosts (open redirect).Changes
Config
AllowedRedirectHosts []stringtoconfig.Auth, sourced fromAUTH_ALLOWED_REDIRECT_HOSTS(comma-separated hostnames)Auth Controller
AuthCallbacknow reads the request body, validatesredirectbefore delegating to the provider, then restores the body for the provider to consumevalidateRedirectmethod enforces:/foo) → always allowed//evil.com) → always rejectedAllowedRedirectHosts; when the list is empty, all absolute redirects are rejectedTests
TestValidateRedirect— unit tests covering relative, protocol-relative, allowed, and disallowed URL casesTestAuthCallbackRejectsDisallowedRedirect— handler-level tests confirming disallowed absolute redirects return HTTP 400 while valid ones proceed to authOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.