Skip to content

replacing all de firstWhere by forEach #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tidianeb5 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

replacing all de firstWhere by forEach #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f29de
replacing all de firstWhere by forEach
tidianeb5 Jan 30, 2023
0660370
enable 'arrow_drop_down' icon to open dropdown menu
tidianeb5 Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions lib/select_form_field.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ class SelectFormField extends FormField<String> {
width: 10,
margin: EdgeInsets.all(0),
child: TextButton(
onPressed: () {},
onPressed: type == SelectFormFieldType.dialog
? state._showSelectFormFieldDialog
: state._showSelectFormFieldMenu,
child: Icon(Icons.arrow_drop_down),
),
),
Expand Down Expand Up @@ -476,10 +478,12 @@ class _SelectFormFieldState extends FormFieldState<String> {

if (_effectiveController?.text != null &&
_effectiveController?.text != '') {
_item = widget.items?.firstWhere(
(lmItem) => lmItem['value'].toString() == _effectiveController?.text,
orElse: () => <String, dynamic>{},
);
widget.items?.forEach((Map<String, dynamic> lmItem) {
if (lmItem['value'].toString() == _effectiveController?.text) {
_item = lmItem;
return;
}
});

if (_item!.length > 0) {
_labelController.text =
Expand Down Expand Up @@ -536,10 +540,12 @@ class _SelectFormFieldState extends FormFieldState<String> {
);

if (lvPicked != null && lvPicked != value) {
_item = widget.items?.firstWhere(
(lmItem) => lmItem['value'].toString() == lvPicked,
orElse: () => <String, dynamic>{},
);
widget.items?.forEach((Map<String, dynamic> lmItem) {
if (lmItem['value'].toString() == lvPicked) {
_item = lmItem;
return;
}
});

if (_item!.length > 0) {
_labelController.text =
Expand Down Expand Up @@ -623,7 +629,7 @@ class _SelectFormFieldState extends FormFieldState<String> {
RelativeRect _buttonMenuPosition(BuildContext poContext) {
final RenderBox loBar = poContext.findRenderObject() as RenderBox;
final RenderBox loOverlay =
Overlay.of(poContext)?.context.findRenderObject() as RenderBox;
Overlay.of(poContext).context.findRenderObject() as RenderBox;
const Offset loOffset = Offset.zero;

final RelativeRect loPosition = RelativeRect.fromRect(
Expand Down