Skip to content

Conversation

@BrandonStalnaker
Copy link
Collaborator

Background

  • Our next major release will update the minimum release version to 15.6. In addition to removing code that is no longer necessary we also wanted to use this opportunity to remove all uses deprecated of deprecated code as well. Saving AppDelegate proxy and related methods https://rokt.atlassian.net/browse/SDKE-553

What Has Changed

  • Updated minimum release version to 15.6 and removed longstanding deprecated code.

Checklist

  • I have performed a self-review of my own code.
  • [] I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Dec 1, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner December 1, 2025 19:11
@BrandonStalnaker BrandonStalnaker force-pushed the feat/SDKE-554-Update-Minimum-Release-Version-And-Remove-Deprecated-Code branch 2 times, most recently from 9b7d56d to 5878366 Compare December 1, 2025 20:24
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker force-pushed the feat/SDKE-550-Implement-Manual-SceneDelegate-Support branch 2 times, most recently from e756cb4 to c607910 Compare December 3, 2025 20:40
@BrandonStalnaker BrandonStalnaker force-pushed the feat/SDKE-550-Implement-Manual-SceneDelegate-Support branch from c607910 to b4767f1 Compare December 3, 2025 20:57
@denischilik denischilik self-requested a review December 4, 2025 21:17
Copy link
Contributor

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of great cleanup and modernization work is done here, but the PR is quite large and very difficult to review safely. Some parts also appear to modify behavior, not just update deployment targets or remove deprecated APIs.

To make the review clearer and safer, could we split this into three focused PRs:

  1. deployment target and podspec updates,
  2. removal of deprecated public APIs,
  3. internal logic updates (persistence, networking, utilities)?

@BrandonStalnaker BrandonStalnaker force-pushed the feat/SDKE-554-Update-Minimum-Release-Version-And-Remove-Deprecated-Code branch from 5878366 to 8945413 Compare December 5, 2025 14:50
jamesnrokt
jamesnrokt previously approved these changes Dec 5, 2025
do {
return try NSKeyedUnarchiver.unarchivedObject(ofClass: MPUploadSettings.self, from: data)
} catch {
print(error)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should these prints be going to logger instead?

@BrandonStalnaker
Copy link
Collaborator Author

BrandonStalnaker commented Dec 5, 2025

I broke this into three commits and corresponding PRs based off Denis' request. Thanks for looking @denischilik @nickolas-dimitrakas @jamesnrokt @rmi22186

I'm working on James' nit now but I've gotta inject the logger dependency into MPUserDefaults.swift and that gets initialized in a bunch of odd places so it may take a little time (thankfully its in the 3rd of the 3 prs)

feat: Update Minimum Deployment Targets
feat: Remove Deprecated Public APIs
refactor: Update internal logic

Base automatically changed from feat/SDKE-550-Implement-Manual-SceneDelegate-Support to blackout/Phase-1 December 9, 2025 15:21
@BrandonStalnaker BrandonStalnaker dismissed jamesnrokt’s stale review December 10, 2025 19:38

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants