-
Notifications
You must be signed in to change notification settings - Fork 57
feat: Add alias for sha256 identities #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Changes from all commits
ee5e888
81f7352
6cdd6f2
e80cc18
0341a90
79c7537
eeb5578
8d9bc4f
308f87b
b97f566
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,9 +161,9 @@ export interface SDKProductAction { | |
| } | ||
|
|
||
| export interface SDKProduct { | ||
| Sku?: string; | ||
| Name?: string; | ||
| Price?: number; | ||
| Sku: string; | ||
| Name: string; | ||
| Price: number; | ||
| Quantity?: number; | ||
| Brand?: string; | ||
| Variant?: string; | ||
|
|
@@ -173,7 +173,7 @@ export interface SDKProduct { | |
| TotalAmount?: number; | ||
|
|
||
| // https://go.mparticle.com/work/SQDSDKS-4801 | ||
| Attributes?: Record<string, unknown> | null; | ||
| Attributes?: Record<string, unknown>; | ||
| } | ||
|
|
||
| // https://go.mparticle.com/work/SQDSDKS-6949 | ||
|
|
@@ -306,7 +306,7 @@ export const LogLevelType = { | |
| // Currently, this extends MPConfiguration in @types/mparticle__web-sdk | ||
| // and the two will be merged in once the Store module is refactored | ||
| export interface SDKInitConfig | ||
| extends Omit<MPConfiguration, 'dataPlan' | 'logLevel'> { | ||
| extends Omit<MPConfiguration, 'dataPlan' | 'logLevel' | 'identityCallback'> { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was required due to build issues with definitelytyped - the local SDK is actually typed more strongly and is more accurate than DT's definition. Once we deprecated DT, this will be resolved. |
||
| dataPlan?: DataPlanConfig | KitBlockerDataPlan; // TODO: These should be eventually split into two different attributes | ||
| logLevel?: LogLevelType; | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.