-
Notifications
You must be signed in to change notification settings - Fork 57
feat: Add Identity.search for IDSync Search #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
cf25bed
feat: Add Identity.searchAdvertiser for IDSync Search
rmi22186 5382278
feat: Switch Identity.searchAdvertiser to Basic auth (apiKey + secret)
rmi22186 7653323
Revert "feat: Switch Identity.searchAdvertiser to Basic auth (apiKey …
rmi22186 b366bbd
feat: Report searchAdvertiser network errors via ErrorReportingDispat…
rmi22186 bb58f23
fix: Address cursor-bot review on searchAdvertiser
rmi22186 d6cefa0
fix: Deliver correct callback shape on searchAdvertiser opt-out
rmi22186 4b4c12f
refactor: Use const for searchAdvertiser locals in identity.js
rmi22186 7095652
fix: Wrap searchAdvertiser request setup in the existing try/catch
rmi22186 e496209
refactor: Tighten searchAdvertiser surface; cache-bust /v1/search URL
rmi22186 3f9d142
fix: Address ultrareview findings on searchAdvertiser
rmi22186 0d7312d
chore: Tighten searchAdvertiser docs and drop redundant test
rmi22186 2ebcbb4
refactor: Rename searchAdvertiser to searchWorkspace
rmi22186 fdfc04a
update query parameter
rmi22186 3a17b19
refactor: Rename Identity.searchWorkspace to Identity.search
rmi22186 e3e190f
refactor: Extract executeSearchRequest into identity-utils.ts
rmi22186 d73b680
refactor: Prefix Search type names with Identity
rmi22186 d7501b3
refactor: Address PR #1255 review nits on Identity.search
rmi22186 0feca7a
refactor: Address PR #1255 review nits + snippet stub for Identity.se…
rmi22186 4246883
fix: Use destructured _ErrorReportingDispatcher in executeSearchRequest
rmi22186 5f12367
test: Add Identity.search coverage for snippet + stub
rmi22186 b605284
refactor: Use Date.now() in buildIdentitySearchEnvelope
rmi22186 723e7e8
Apply suggestion from @alexs-mparticle
rmi22186 e47d52a
refactor: Propagate Environment type and drop redundant Response casts
rmi22186 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.