dr_wav: Validate ADPCM block header size against data chunk size#299
Open
timblechmann wants to merge 1 commit intomackron:masterfrom
Open
dr_wav: Validate ADPCM block header size against data chunk size#299timblechmann wants to merge 1 commit intomackron:masterfrom
timblechmann wants to merge 1 commit intomackron:masterfrom
Conversation
Add a guard to ensure `dataChunkSize` is not smaller than the calculated total block header size (`blockCount * (6 * fmt.channels)`) when parsing ADPCM data. If the header size exceeds the data chunk size, the file is invalid, so metadata is freed and initialization fails early. This prevents underflow in the PCM frame count calculation and avoids processing malformed or truncated WAV files.
Owner
|
Thanks. Just acknowledging that I've seen this. Will report back when I get a chance to properly review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a guard to ensure
dataChunkSizeis not smaller than the calculated total block header size (blockCount * (6 * fmt.channels)) when parsing ADPCM data. If the header size exceeds the data chunk size, the file is invalid, so metadata is freed and initialization fails early.This prevents underflow in the PCM frame count calculation and avoids processing malformed or truncated WAV files.
this file would end up with an invalid totalPCMFrameCount:
notification.wav