Allow use of trix directly with trix_editor_tag by injecting into ActionView::Base

[zachfeldman]

This feels a bit icky to me and like I'm not doing it the true "rails way", but it does work on my project. Any suggestions welcome!

[maclover7]

Hi @zachfeldman! Two quick things about this PR--

1. Would you be able to take a look into Action View's source code to see how Rails does this? Like you pointed out, the solution is a little hacky right now 😬

2. Can you please add some additional test coverage of this new feature?

[zachfeldman]

@maclover7 sure I'd be glad to help.

1. I've looked into Action View's source code and have not found an example similar enough to this project to understand how to autoload and inject this code without injecting into activerecord::base. Some of the examples I've looked at:

• https://github.com/marcelorocks/filterable-models/blob/0e5d91410c65e979856f67e97cd7a6d62afc1023/lib/filterable-models.rb

https://github.com/oshchyhol/chargify_direct/blob/e13af53e99de06922795461d504b0db33c25447c/lib/chargify_direct.rb

• https://github.com/rails/rails/blob/111736ddf6fe81f3e42af37dfa1b0520a8c91473/actionview/lib/action_view/helpers/form_tag_helper.rb (methods are defined directly in modules, not in a module then included in another module, then injected again?)
• https://github.com/rails/rails/blob/111736ddf6fe81f3e42af37dfa1b0520a8c91473/actionview/lib/action_view/helpers/text_helper.rb

My main thesis is that I have to include trix_editor_tag in FormTagHelper so I can call it directly in my code. I've been able to resolve it as defined by defining it directly in the module like so:

module ActionView
  module Helpers

    module FormTagHelper
      def trix_editor_tag(object_name, value, options)
      end
    end

  end
end

However, from here I get stuck in a loop of, "wait, this is already defined above" and trying to include it there instead of defining it (include TrixEditorHelper instead of the method definition above). Or I try to use the Tags::TrixEditor.new(object_name, method, self, options).render method similar to the FormHelper implementation, but it seems silly because that's calling trix_editor_tag underneath it all.

Frankly I'm pretty stumped here, would appreciate any guidance @maclover7 as to what you consider a proper way to inject this into activerecord.

I'm glad to do number 2 once I can take care of number 1! Appreciate any insights you might have.