Add ESP-IDF 5 pulse_cnt driver support#127
Open
rvbc1 wants to merge 2 commits into
Open
Conversation
Migrate PCNT driver for ESP-IDF 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the new ESP-IDF 5 pulse counter driver API.
For ESP-IDF 5 and newer,
ESP32Encodernow usesdriver/pulse_cnt.hinstead of the deprecated legacydriver/pcnt.h. The existing legacy implementation is kept for older ESP-IDF versions.This addresses the deprecated PCNT driver warning reported in #117 without suppressing the warning.
Changes
driver/pulse_cnt.hfor ESP-IDF >= 5.driver/pcnt.hfor older ESP-IDF versions.accum_countfor count accumulation.Testing