unbind method + unit tests + method argument#73
Open
bfirsh wants to merge 4 commits intomadrobby:masterfrom
Open
unbind method + unit tests + method argument#73bfirsh wants to merge 4 commits intomadrobby:masterfrom
bfirsh wants to merge 4 commits intomadrobby:masterfrom
Conversation
Author
|
It also doesn't take into account comma-separated keys or modifiers. I'm doing some work on that now, but it means teasing out the parsing code from assignKey(). |
|
This is much needed. Thanks for working on it. I'd vote for |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is building upon #65 and #69. I've added a "method" argument so you can specify exactly which handler to remove, like in most event systems (e.g.
on('event', method)/off('event', method)).There's a bit of undefined behaviour in the unbind method which needs a design decision though. If the scope is not set, then calling just
unbind('a')will only remove handlers for "a" in the current scope. I think I'd expect it to remove all handlers for "a", like callingoff('event')in an event system. Thoughts?