Extend keymaster to support dispatching key events to elements#76
Open
johnjbarton wants to merge 1 commit intomadrobby:masterfrom
Open
Extend keymaster to support dispatching key events to elements#76johnjbarton wants to merge 1 commit intomadrobby:masterfrom
johnjbarton wants to merge 1 commit intomadrobby:masterfrom
Conversation
key events to elements. Overload key() to include key(descriptor, view, element) where descriptor is the same as the shortcut definition version, view is the dispatch view (defaults to 'window'), element is the dispatch target. Add selftest.html, modified from test.html to issue console.warn for passing tests and console.error for failures
Author
|
Ah, just noticed /test. I guess test.html is really demo.html ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You may not care for this direction, but FYI.
Extend keymaster to support dispatching key events to elements.
Overload key() to include key(descriptor, view, element)
where |descriptor| is the same as the shortcut definition version,
|view| is the dispatch view (defaults to 'window'),
|element| is the dispatch target.
Add selftest.html, modified from test.html to issue console.warn
for passing tests and console.error for failures.
Tests pass but I've not driven this model out on the road yet.