bail if no document so you can require on server#91
Open
blented wants to merge 3 commits intomadrobby:masterfrom
Open
bail if no document so you can require on server#91blented wants to merge 3 commits intomadrobby:masterfrom
blented wants to merge 3 commits intomadrobby:masterfrom
Conversation
Owner
|
What's your use case to require it server-side? |
Author
|
Shared Backbone views rendered on both client and server. The first page Grant
|
useful for shared server / client code like backbone views
- if key doesn't have mod, key isn't set - should continue, not return as there are more keys to check
- I get a "key is not defined" error when requiring, exporting global.key fixes it
Author
|
Added a couple more commits, one for global.key and one for unbindKey. The comments on both commits detail the tweaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useful for shared server / client code like backbone views