Skip to content

feat(setup-magento): mkdir app/etc to allow prevent composer plugin crashing #368

Merged
damienwebdev merged 1 commit into
mage-os:mainfrom
digitalrisedorset:feat/setup-magento-graycore-parity
May 14, 2026
Merged

feat(setup-magento): mkdir app/etc to allow prevent composer plugin crashing #368
damienwebdev merged 1 commit into
mage-os:mainfrom
digitalrisedorset:feat/setup-magento-graycore-parity

Conversation

@digitalrisedorset
Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

After composer create-project --no-install, the Magento directory structure may not yet contain app/etc.
Some composer plugin/install flows expect this directory to already exist, which can lead to failures during setup workflows.

Fixes: N/A

What is the new behavior?

Adds a defensive filesystem initialization step to ensure app/etc exists immediately after project creation.
This restores parity with the upstream Graycore implementation and improves setup workflow reliability for extension mode installs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This change intentionally mirrors the existing safeguard present in the Graycore implementation of setup-magento.

@digitalrisedorset digitalrisedorset requested a review from a team as a code owner May 14, 2026 15:26
Copy link
Copy Markdown
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev changed the title feat(setup-magento): restore Graycore parity safeguards feat(setup-magento): mkdir app/etc to allow prevent composer plugin crashing May 14, 2026
@damienwebdev damienwebdev merged commit f54dcc5 into mage-os:main May 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants