Skip to content

[WEB-6734] fix: circular progress indicator stroke color#8802

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
fix-circular-progress-indicator
Mar 26, 2026
Merged

[WEB-6734] fix: circular progress indicator stroke color#8802
sriramveeraghanta merged 1 commit intopreviewfrom
fix-circular-progress-indicator

Conversation

@b-saikrishnakanth
Copy link
Copy Markdown
Collaborator

@b-saikrishnakanth b-saikrishnakanth commented Mar 26, 2026

Description

This update fixes the color tokens for CircularProgressIndicator

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots and Media (if applicable)

Before
image

After
image

Test Scenarios

References

Summary by CodeRabbit

  • Style
    • Updated the default color appearance of the circular progress indicator component.

@makeplane
Copy link
Copy Markdown

makeplane bot commented Mar 26, 2026

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fca89d4a-e24b-429c-ac64-9a98351fce04

📥 Commits

Reviewing files that changed from the base of the PR and between d94a269 and 410bf50.

📒 Files selected for processing (1)
  • packages/ui/src/progress/circular-progress-indicator.tsx

📝 Walkthrough

Walkthrough

Updated the default strokeColor prop in CircularProgressIndicator from "stroke-success" to "stroke-success-secondary", which changes the default CSS class applied to the rendered SVG circle when the prop is not explicitly provided.

Changes

Cohort / File(s) Summary
Circular Progress Indicator Styling
packages/ui/src/progress/circular-progress-indicator.tsx
Changed default strokeColor prop value from "stroke-success" to "stroke-success-secondary", updating the default CSS class applied to the SVG circle element.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A circle turns from green to teal,
A subtle shift, a softer feel,
The secondary hue takes its place,
Progress shown with gentler grace,
One small change, a swifter stride! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the circular progress indicator's stroke color property.
Description check ✅ Passed The description covers the main change and includes before/after screenshots, but Test Scenarios and References sections are empty or incomplete.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-circular-progress-indicator

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sriramveeraghanta sriramveeraghanta merged commit ce401c7 into preview Mar 26, 2026
10 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-circular-progress-indicator branch March 26, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants