Skip to content

Conversation

@tristanpwdennis
Copy link
Collaborator

Will update this to add hashing support to cohort_diversity_stats too.

@tristanpwdennis tristanpwdennis mentioned this pull request Jun 19, 2025
@leehart
Copy link
Collaborator

leehart commented Jun 19, 2025

Linking issue #798

@leehart
Copy link
Collaborator

leehart commented Aug 8, 2025

Looks like this is just waiting for a review.

@leehart leehart requested a review from jonbrenas August 8, 2025 08:37
@leehart
Copy link
Collaborator

leehart commented Oct 21, 2025

Just noting the current integration test failures here for visibility:

=========================== short test summary info ============================
FAILED tests/integration/test_ag3.py::test_cross_metadata - AssertionError: assert ***'AC0300-C', ...C0306-C', ...*** == ***'AC0300-C', ...C0306-C', ...***
  
  Extra items in the right set:
  'AD0425-C'
  'AD0733-C'
[...]
FAILED tests/integration/test_ag3.py::test_phenotypes_with_snp_calls - IndexError: Boolean array size 22977 is used to index array with shape (10001, 22605, 2).
============ 2 failed, 109 passed, 2 warnings in 824.57s (0:13:44) =============

Also the current Notebook failure:

[NbConvertApp] Converting notebook notebooks/extra_metadata.ipynb to notebook
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/jupyter_core/utils/__init__.py", line 154, in wrapped
    asyncio.get_running_loop()
RuntimeError: no running event loop

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.12.11/x64/bin/jupyter-nbconvert", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/jupyter_core/application.py", line 284, in launch_instance
    super().launch_instance(argv=argv, **kwargs)
  File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/traitlets/config/application.py", line 1075, in launch_instance
    app.start()
  File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/nbconvert/nbconvertapp.py", line 420, in start
    self.convert_notebooks()
  File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/nbconvert/nbconvertapp.py", line 597, in convert_notebooks
    self.convert_single_notebook(notebook_filename)
  File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/nbconvert/nbconvertapp.py", line 563, in convert_single_notebook
    output, resources = self.export_single_notebook(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/nbconvert/nbconvertapp.py", line 487, in export_single_notebook
    output, resources = self.exporter.from_filename(
    820     data = indexing.apply_indexer(indexable, indexer)

File /opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/xarray/core/variable.py:656, in Variable._broadcast_indexes(self, key)
    650 if all(
    651     (isinstance(k, BASIC_INDEXING_TYPES) and not isinstance(k, bool))
    652     for k in key
    653 ):
    654     return self._broadcast_indexes_basic(key)
--> 656 self._validate_indexers(key)
    657 # Detect it can be mapped as an outer indexer
    658 # If all key is unlabeled, or
    659 # key can be mapped as an OuterIndexer.
    660 if all(not isinstance(k, Variable) for k in key):

File /opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/xarray/core/variable.py:700, in Variable._validate_indexers(self, key)
    698 if k.dtype.kind == "b":
    699     if self.shape[self.get_axis_num(dim)] != len(k):
--> 700         raise IndexError(
    701             f"Boolean array size ***len(k):d*** is used to index array "
    702             f"with shape ***self.shape***."
    703         )
    704     if k.ndim > 1:
    705         raise IndexError(
    706             f"***k.ndim***-dimensional boolean indexing is not supported. "
    707         )

IndexError: Boolean array size 3453 is used to index array with shape (52226568, 3081, 2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants