Skip to content

test(client/doublezero): return different min, max, avg from make_latency #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axaysagathiya wants to merge 3 commits into
base: main
Choose a base branch
from
+48 −78
Open

test(client/doublezero): return different min, max, avg from make_latency #3564

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b5104c
return different min, max, avg from make_latency
axaysagathiya Apr 22, 2026
1650f39
Make latency selection tests adversarial
axaysagathiya Apr 23, 2026
ab52ff5
clean up
axaysagathiya Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 48 additions & 78 deletions client/doublezero/src/dzd_latency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,14 +314,20 @@ mod tests {
)
}

fn make_latency(pk: &str, latency_ns: i64, reachable: bool) -> LatencyRecord {
fn make_latency(
pk: &str,
min_latency_ns: i64,
avg_latency_ns: i64,
max_latency_ns: i64,
reachable: bool,
) -> LatencyRecord {
LatencyRecord {
device_pk: pk.to_string(),
device_code: "device".to_string(),
device_ip: "0.0.0.0".to_string(),
min_latency_ns: latency_ns,
max_latency_ns: latency_ns,
avg_latency_ns: latency_ns,
min_latency_ns,
avg_latency_ns,
max_latency_ns,
reachable,
}
}
Expand All @@ -338,9 +344,9 @@ mod tests {
devices.insert(pk3, dev3);

let latencies = vec![
make_latency(&pk1.to_string(), 10000000, true),
make_latency(&pk2.to_string(), 20000000, false),
make_latency(&pk3.to_string(), 5000000, true),
make_latency(&pk1.to_string(), 10000000, 11000000, 12000000, true),
make_latency(&pk2.to_string(), 20000000, 21000000, 22000000, false),
make_latency(&pk3.to_string(), 5000000, 5000000, 5000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -377,8 +383,8 @@ mod tests {
devices.insert(pk2, dev2);

let latencies = vec![
make_latency(&pk1.to_string(), 10000000, true),
make_latency(&pk2.to_string(), 11000000, true),
make_latency(&pk1.to_string(), 10000000, 10500000, 11000000, true),
make_latency(&pk2.to_string(), 11000000, 11500000, 12000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -408,9 +414,9 @@ mod tests {
devices.insert(pk3, dev3);

let latencies = vec![
make_latency(&pk1.to_string(), 12000000, true),
make_latency(&pk2.to_string(), 9000000, true),
make_latency(&pk3.to_string(), 15000000, true),
make_latency(&pk1.to_string(), 12000000, 5000000, 14000000, true),
make_latency(&pk2.to_string(), 9000000, 20000000, 11000000, true),
make_latency(&pk3.to_string(), 15000000, 15000000, 17000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -440,9 +446,9 @@ mod tests {
devices.insert(pk3, dev3);

let latencies = vec![
make_latency(&pk1.to_string(), 12000000, false), // unreachable
make_latency(&pk2.to_string(), 9000000, false), // unreachable
make_latency(&pk3.to_string(), 15000000, true), // reachable
make_latency(&pk1.to_string(), 12000000, 13000000, 14000000, false), // unreachable
make_latency(&pk2.to_string(), 9000000, 10000000, 11000000, false), // unreachable
make_latency(&pk3.to_string(), 15000000, 16000000, 17000000, true), // reachable
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -470,8 +476,8 @@ mod tests {
devices.insert(pk2, dev2);

let latencies = vec![
make_latency(&pk1.to_string(), 9000000, true),
make_latency(&pk2.to_string(), 12000000, true),
make_latency(&pk1.to_string(), 9000000, 10000000, 11000000, true),
make_latency(&pk2.to_string(), 12000000, 13000000, 14000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -499,8 +505,8 @@ mod tests {
devices.insert(pk2, dev2);

let latencies = vec![
make_latency(&pk1.to_string(), 12000000, true),
make_latency(&pk2.to_string(), 9000000, true),
make_latency(&pk1.to_string(), 12000000, 13000000, 14000000, true),
make_latency(&pk2.to_string(), 9000000, 10000000, 11000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -534,9 +540,9 @@ mod tests {
devices.insert(pk3, dev3);

let latencies = vec![
make_latency(&pk1.to_string(), 12000000, true),
make_latency(&pk2.to_string(), 5000000, true), // lowest but will be excluded
make_latency(&pk3.to_string(), 15000000, true),
make_latency(&pk1.to_string(), 12000000, 13000000, 14000000, true),
make_latency(&pk2.to_string(), 5000000, 6000000, 7000000, true), // lowest but will be excluded
make_latency(&pk3.to_string(), 15000000, 16000000, 17000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -962,24 +968,8 @@ mod tests {
// pk1: low min, high avg. pk2: high min, low avg.
// Sorted by min: pk1 first. Sorted by avg: pk2 first.
let latencies = vec![
LatencyRecord {
device_pk: pk1.to_string(),
device_code: "device".to_string(),
device_ip: "0.0.0.0".to_string(),
min_latency_ns: 5_000_000, // lower min → should be first
max_latency_ns: 30_000_000,
avg_latency_ns: 25_000_000, // higher avg
reachable: true,
},
LatencyRecord {
device_pk: pk2.to_string(),
device_code: "device".to_string(),
device_ip: "0.0.0.0".to_string(),
min_latency_ns: 15_000_000, // higher min
max_latency_ns: 20_000_000,
avg_latency_ns: 8_000_000, // lower avg → would be first if sorted by avg
reachable: true,
},
make_latency(&pk1.to_string(), 5000000, 25000000, 30000000, true),
make_latency(&pk2.to_string(), 15000000, 8000000, 20000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -1011,24 +1001,8 @@ mod tests {
// pk1: low min, high avg. pk2: high min, low avg.
// Should select pk1 (lower min).
let latencies = vec![
LatencyRecord {
device_pk: pk1.to_string(),
device_code: "device".to_string(),
device_ip: "0.0.0.0".to_string(),
min_latency_ns: 5_000_000, // lower min → should win
max_latency_ns: 30_000_000,
avg_latency_ns: 25_000_000, // higher avg
reachable: true,
},
LatencyRecord {
device_pk: pk2.to_string(),
device_code: "device".to_string(),
device_ip: "0.0.0.0".to_string(),
min_latency_ns: 15_000_000, // higher min → should lose
max_latency_ns: 20_000_000,
avg_latency_ns: 8_000_000, // lower avg → would win if sorted by avg
reachable: true,
},
make_latency(&pk1.to_string(), 5000000, 25000000, 30000000, true),
make_latency(&pk2.to_string(), 15000000, 20000000, 8000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -1064,24 +1038,8 @@ mod tests {
devices.insert(pk2, dev2);

let latencies = vec![
LatencyRecord {
device_pk: pk1.to_string(),
device_code: "device".to_string(),
device_ip: "0.0.0.0".to_string(),
min_latency_ns: 5_000_000, // lower min → should win
max_latency_ns: 30_000_000,
avg_latency_ns: 25_000_000, // higher avg
reachable: true,
},
LatencyRecord {
device_pk: pk2.to_string(),
device_code: "device".to_string(),
device_ip: "0.0.0.0".to_string(),
min_latency_ns: 13_000_000, // higher min → current device
max_latency_ns: 20_000_000,
avg_latency_ns: 6_000_000, // lower avg (would anchor tolerance if avg-seeded)
reachable: true,
},
make_latency(&pk1.to_string(), 5000000, 25000000, 30000000, true),
make_latency(&pk2.to_string(), 13000000, 6000000, 20000000, true),
];

let mut controller = MockServiceController::new();
Expand Down Expand Up @@ -1134,7 +1092,13 @@ mod tests {
let mut devices = HashMap::new();
devices.insert(pk1, dev1);

let latencies = vec![make_latency(&pk1.to_string(), 10000000, true)];
let latencies = vec![make_latency(
&pk1.to_string(),
10000000,
11000000,
12000000,
true,
)];
let call_count = std::sync::Arc::new(std::sync::atomic::AtomicU32::new(0));
let call_count_clone = call_count.clone();
let latencies_clone = latencies.clone();
Expand Down Expand Up @@ -1190,7 +1154,13 @@ mod tests {
devices.insert(pk1, dev1);

// Device exists and is activated, but unreachable
let latencies = vec![make_latency(&pk1.to_string(), 10000000, false)];
let latencies = vec![make_latency(
&pk1.to_string(),
10000000,
11000000,
12000000,
false,
)];

let mut controller = MockServiceController::new();
controller.expect_latency().returning(move || {
Expand Down