chore: cover multiple VRFs for unit test#3640
Open
0xzrf wants to merge 1 commit intomalbeclabs:mainfrom
Open
Conversation
Author
|
hey @nikw9944 Can you review this PR? |
9478ae2 to
aa5d34d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Describe what changed in the PR
Updated
render_peer_removal_successfulincontrolplane/controller/internal/controller/render_test.goto cover multi-VRF scenarios by switchingUnicastVrfsfrom[1]→[1, 2]and assigning tunnels across VRFs (keeping tunnel 500 in VRF1; moving 501/502 to VRF2).Updated the golden fixture
controlplane/controller/internal/controller/fixtures/unknown.peer.removal.tmplto match the expected rendered output for multi-VRF peer removal (adds vrf2routing/configsections, moves tunnel VRF assignments, and ensures unknown-peer no neighbor cleanup is rendered under each VRF).Explain why the change is necessary
quoting from this issue:
Is there supporting documentation or external resources that explain the change? No
Is a CHANGELOG.md update needed? No
Testing Verification
Closes #3633