Bump lightGBM and numpy to fix CVE-2024-43598#44
Open
vee1e wants to merge 2 commits intomandiant:masterfrom
Open
Bump lightGBM and numpy to fix CVE-2024-43598#44vee1e wants to merge 2 commits intomandiant:masterfrom
vee1e wants to merge 2 commits intomandiant:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the versions to
lightgbm>="4.6.0"andnumpy = "== 1.26.0"to fix the presence of CVE-2024-43598, as mentioned in #42 .Added an assertion and workaround for using the older model files, currently all test cases pass and
rank_stringsfunctions perfectly.I'd also request to have the model dataset and training files published publicly if possible as mentioned in the discussion section of your README. It would make it easier for contributors to develop and expand on the project.