direnv shim, part II#10
Open
faukah wants to merge 1 commit into
Open
Conversation
faukah
force-pushed
the
faukah/push-urlnlvwonlqm
branch
2 times, most recently
from
1a7d16a to
454fd49
Compare
faukah
force-pushed
the
faukah/push-urlnlvwonlqm
branch
4 times, most recently
from
5260a29 to
45dabcd
Compare
faukah
force-pushed
the
faukah/push-urlnlvwonlqm
branch
from
45dabcd to
b54dccc
Compare
atagen
reviewed
May 31, 2026
| all_watch_files.extend(watch_files.clone()); | ||
|
|
||
| let token = compute_layer_key(&watch_files); | ||
| let dir = path.to_string_lossy(); |
Contributor
There was a problem hiding this comment.
we should probably be more careful w path handling
atagen
reviewed
May 31, 2026
| cadeExe = lib.getExe cade; | ||
| in | ||
| writeScriptBin "direnv" ( | ||
| builtins.replaceStrings [ "@bash@" "@cade@" ] [ "${bash}" cadeExe ] ( |
Contributor
There was a problem hiding this comment.
can just be an inline block with ${} substitution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
successor of #7.
This PR implements cade-backed direnv compatibility:
cade export json, producing a direnv-compatible JSON env delta.direnvshim:direnv export json->cade export json.#direnv-compat.#direnv-compat-bashprograms.cade.direnvCompat = truenix develop --command ... env -0instead ofnix print-dev-env --json, soshellHookmutations likePATHchanges are captured.src/env_delta.rsto centralize env diff rendering for shell output and JSON export.EnvOutputvsShellOutput, and emits NushellPATHas a list.