Upgrade to AWS SDK for Javascript V3 #158
Conversation
| }, | ||
| Description: 'my description', | ||
| Environment: { Variables: { A: 'a' } }, | ||
| Environment: { Variables: { MyCoolEnv: 'a' } }, |
There was a problem hiding this comment.
new cfn-lint is catching these as invalid environments thus we shouldnt test with these
| Handler: 'index.something', | ||
| KmsKeyArn: 'arn:aws:kms:us-east-1:123456789012:key/fake', | ||
| Layers: ['arn:aws:fake:layer/abc'], | ||
| Layers: ['arn:aws:lambda:us-east-2:590474943231:layer:AWS-Parameters-and-Secrets-Lambda-Extension:4'], |
There was a problem hiding this comment.
new cfn-lint is catching these as invalid layer arn thus we shouldnt test with these
| TracingConfig: { Mode: 'Active' }, | ||
| VpcConfig: { | ||
| SecurityGroupIds: ['sg-12345'], | ||
| SecurityGroupIds: ['sg-12345678'], |
There was a problem hiding this comment.
new cfn-lint is catching these as invalid security groups thus we shouldnt test with these
| LogicalName: 'MyQueue', | ||
| VisibilityTimeout: 60, | ||
| maxReceiveCount: 100, | ||
| ContentBasedDeduplication: true, |
There was a problem hiding this comment.
new cfn-lint is catching these as invalid thus we shouldnt test with these
| aws-sam-cli==1.94.0 | ||
| cfn-lint==0.78.1 | ||
| aws-sam-cli==1.142.1 | ||
| cfn-lint==1.36.1 |
There was a problem hiding this comment.
latest dev dependencies used in tests
There was a problem hiding this comment.
nit: can we use the aws-sam-cli >= 1.142.1 to prevent this type of issue in the future?
| }, | ||
| "dependencies": { | ||
| "aws-sdk": "^2.1425.0", | ||
| "@aws-sdk/client-cloudformation": "^3.848.0", |
There was a problem hiding this comment.
Removes aws-sdk and only use @aws-sdk/client-cloudformation
3 participants
@aws-sdk/client-cloudformationas a runtime dependency.@aws-sdk/client-cloudformation.node22.x