Open
Conversation
62a5455 to
050c17c
Compare
8b67dc4 to
269f046
Compare
|
@corporategoth it looks like this failed to build due to timeout - should we move this out of "ready for review"? Also I would love to see an explanation of why we need to switch the boost compile and any implications this may have on other boost-using systems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 7 libraries:
It also adds a different compile of boost (1.75.0-clang-libc++) - specifically compiled with clang and linked against libc++ (as opposed to libstdc++). Also compiled with c++20.