Skip to content

Avoid npm warnings by supporting MODULE_BINARY_HOST_MIRROR env variable #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yunnysunny wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −2
Open

Avoid npm warnings by supporting MODULE_BINARY_HOST_MIRROR env variable #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
290cdc1
Enhance binary host mirror configuration handling
yunnysunny Apr 7, 2026
83685cb
Replace all - in module_name to _
yunnysunny Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/util/versioning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,9 @@ module.exports.evaluate = function(package_json, options, napi_build_version) {
// support host mirror with npm config `--{module_name}_binary_host_mirror`
// e.g.: https://github.com/node-inspector/v8-profiler/blob/master/package.json#L25
// > npm install v8-profiler --profiler_binary_host_mirror=https://registry.npmmirror.com/node-inspector/
const validModuleName = opts.module_name.replace('-', '_');
const host = process.env['npm_config_' + validModuleName + '_binary_host_mirror'] || package_json.binary.host;
const validModuleName = opts.module_name.replace(/-/g, '_');
const envNameSuffix = validModuleName + '_binary_host_mirror';
const host = process.env['npm_config_' + envNameSuffix] || process.env[envNameSuffix.toUpperCase()] || package_json.binary.host;
Comment thread
yunnysunny marked this conversation as resolved.
opts.host = fix_slashes(eval_template(host, opts));
opts.module_path = eval_template(package_json.binary.module_path, opts);
// now we resolve the module_path to ensure it is absolute so that binding.gyp variables work predictably
Expand Down
20 changes: 20 additions & 0 deletions test/versioning.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,26 @@ test('should detect custom binary host from env', (t) => {
t.end();
});

test('should detect custom binary host from uppercase env', (t) => {
const mock_package_json = {
'name': 'test',
'main': 'test.js',
'version': '0.1.0',
'binary': {
'module_name': 'test',
'module_path': './lib/binding/{configuration}/{toolset}/{name}',
'remote_path': './{name}/v{version}/{configuration}/{version}/{toolset}/',
'package_name': '{module_name}-v{major}.{minor}.{patch}-{prerelease}+{build}-{toolset}-{node_abi}-{platform}-{arch}.tar.gz',
'host': 'https://some-bucket.s3.us-east-1.amazonaws.com'
}
};
process.env.TEST_BINARY_HOST_MIRROR = 'https://registry.npmmirror.com/node-inspector/';
const opts = versioning.evaluate(mock_package_json, {});
t.equal(opts.host, 'https://registry.npmmirror.com/node-inspector/');
delete process.env.TEST_BINARY_HOST_MIRROR;
Comment thread
yunnysunny marked this conversation as resolved.
t.end();
});

test('should detect libc', (t) => {
const mock_package_json = {
'name': 'test',
Expand Down