Lazy-load properties upon first getProperties() call#53
Open
brunoabinader wants to merge 18 commits intomasterfrom
Open
Lazy-load properties upon first getProperties() call#53brunoabinader wants to merge 18 commits intomasterfrom
brunoabinader wants to merge 18 commits intomasterfrom
Conversation
… had a command count of 1
…peated uses of this tactic to allocate and leave multiple vectors, shifted max reserve from 10mb to 1mb.
Prevent Massive Over Allocation
Align property parsing with JS implementation
… y position if multiple int32_t deltas push a value outside of the max range of an int32_t. This change bumps the x and y values to int64_t. It is still possible to have an overflow or underflow, however, this is much less likely and would require a large number of large deltas to reach this point.
Preventing Overflows and Underflows on Points
It seems that the QNX 7 compiler (i.e qcc based on GCC 5.4.0 with libc++ from LLVM) has a limited c++11 feature support and causing compilation errors with the inheriting constructors. This patch fixes the issues by providing the universal forwarding constructor. Also, resolves an ambiguous overload error with optional<T>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that the data source for generating the properties map doesn't change after the
featureobject is instantiated, this PR:getProperties()callsgetProperties()logic ingetValue()