-
Notifications
You must be signed in to change notification settings - Fork 1
fix: display closing reason in issue detail Recent Events section #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The closing reason was being captured and stored in the database but not displayed in the UI. Updated the Recent Events section in detail.html to show the event comment (which contains the closing reason), the actor who made the change, and status transitions. This makes the closing reason visible to users when viewing an issue's audit trail. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
WalkthroughThe Issue Detail Page and UI Components are enhanced to display comprehensive audit trail information. The Close button label is updated to indicate reason storage in the audit trail, and a new Recent Events section presents detailed event entries with timestamps, actors, event types, and optional fields like value changes and comments. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
assets/beady/templates/detail.html (1)
192-192: Minor: Empty Comment strings will render empty emphasis tags.Line 192 checks
{{if .Comment}}but will still render<em></em>if Comment is an empty string (empty string is truthy in Go conditionals only when pointer nil). This is cosmetic but consider filtering empty comments at the backend or adding length check.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CLAUDE.md(1 hunks)assets/beady/templates/detail.html(1 hunks)
🔇 Additional comments (2)
CLAUDE.md (1)
242-242: Documentation updates accurately reflect the Recent Events feature.The changes to
CLAUDE.mdcorrectly document the UI enhancements: the close button description notes reason storage in the audit trail, and the Recent Events section description comprehensively covers the new audit trail display with timestamps, actors, and event details.Also applies to: 246-246
assets/beady/templates/detail.html (1)
189-193: Verify data consistency for optional fields in events.The template conditionally renders
.OldValueand.NewValuetogether, but the check only verifies.OldValuepresence. If.NewValueis ever absent or empty when.OldValueexists, the output will appear incomplete.Run the following script to search for how
.Eventsdata structure is populated in the backend:
Summary
Test Plan
Implementation Details
Updated detail.html Recent Events section to render:
{{.CreatedAt}}and{{.Actor}}){{.EventType}}){{.OldValue}} → {{.NewValue}}){{.Comment}})Updated CLAUDE.md documentation to describe Recent Events section.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
UI Changes