Skip to content

Fix makeRequest to return Promise for proper async chaining #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ephigenia merged 3 commits into from
Nov 26, 2025
Merged

Fix makeRequest to return Promise for proper async chaining #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23d878a
Initial plan
Copilot Nov 26, 2025
a8affa9
Plan to fix makeRequest return statement
Copilot Nov 26, 2025
f3b566c
Fix makeRequest to return Promise and update tests
Copilot Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/mite-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ module.exports = function(options) {

var body = response.data;
var statusCode = response.status;
var method = (response.config?.method || 'GET').toUpperCase();
var method = (response.config && response.config.method || 'GET').toUpperCase();

switch (method) {
case 'GET':
Expand Down Expand Up @@ -90,7 +90,7 @@ module.exports = function(options) {
requestOptions.headers['X-MiteApiKey'] = options.apiKey;
}

options.request(requestOptions)
return options.request(requestOptions)
.then(function(response) {
handleResponse(null, response, done);
})
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

74 changes: 37 additions & 37 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ describe('Configuration', function() {
mite = miteApi();
mite.getOption('account').should.be.false;
mite.getOption('apiKey').should.be.false;
return mite.getOption('applicationName').should.be.false;
mite.getOption('applicationName').should.be.false;
});
return it('should be overwrite default options', function() {
var mite;
Expand All @@ -22,7 +22,7 @@ describe('Configuration', function() {
});
mite.getOption('account').should.be.equal('account');
mite.getOption('apiKey').should.be.equal('apikey');
return mite.getOption('applicationName').should.be.equal('applicationname');
mite.getOption('applicationName').should.be.equal('applicationname');
});
});

Expand All @@ -34,7 +34,7 @@ describe('URL', function() {
apiKey: 'apikey',
applicationName: 'applicationname'
});
return mite.getUrl('services').should.equal('https://account.mite.de/services.json');
mite.getUrl('services').should.equal('https://account.mite.de/services.json');
});
it('should be a valid API-URL with an api_key query-parameter', function() {
var mite;
Expand All @@ -44,7 +44,7 @@ describe('URL', function() {
applicationName: 'applicationname',
query: true
});
return mite.getUrl('services').should.equal('https://account.mite.de/services.json?api_key=apikey');
mite.getUrl('services').should.equal('https://account.mite.de/services.json?api_key=apikey');
});
it('should be a valid API-URL with a filter query-parameter', function() {
var mite;
Expand All @@ -53,7 +53,7 @@ describe('URL', function() {
apiKey: 'apikey',
applicationName: 'applicationname'
});
return mite.getUrl('services', {
mite.getUrl('services', {
limit: 50,
page: 2
}).should.equal('https://account.mite.de/services.json?limit=50&page=2');
Expand All @@ -65,7 +65,7 @@ describe('URL', function() {
apiKey: 'apikey',
applicationName: 'applicationname'
});
return mite.getUrl('dailyDate', {
mite.getUrl('dailyDate', {
year: 2013,
month: 1,
day: 1
Expand Down Expand Up @@ -97,7 +97,7 @@ describe('API', function() {
request: getAccountRequestMock
});
return it('when not found calls the callback with an error object', function(done) {
return mite.getAccount(function(err) {
mite.getAccount(function(err) {
err.should.be.an.instanceOf(Error);
err.message.should.equal('Whoops! We couldn\'t find your account');
return done();
Expand Down Expand Up @@ -127,7 +127,7 @@ describe('API', function() {
request: deleteProjectRequestMock
});
return it('calls done with rror when project was not found', function(done) {
return mite.deleteProject(21, function(err) {
mite.deleteProject(21, function(err) {
err.should.be.an.instanceOf(Error);
err.message.should.equal('Der Datensatz ist nicht vorhanden');
return done();
Expand All @@ -143,7 +143,7 @@ describe('API', function() {
request: axiosMock
});
it('should be get all services', function(done) {
return mite.getServices(function(err, services) {
mite.getServices(function(err, services) {
services.should.have.length(1);
services[0].service.should.have.property('billable');
services[0].service.should.have.property('created_at');
Expand All @@ -157,7 +157,7 @@ describe('API', function() {
});
});
it('should be get all archived services', function(done) {
return mite.getArchivedServices(function(err, services) {
mite.getArchivedServices(function(err, services) {
services.should.have.length(1);
services[0].service.should.have.property('billable');
services[0].service.should.have.property('created_at');
Expand All @@ -171,7 +171,7 @@ describe('API', function() {
});
});
it('should be get one service', function(done) {
return mite.getService(1, function(err, service) {
mite.getService(1, function(err, service) {
service.service.should.have.property('billable');
service.service.should.have.property('created_at');
service.service.should.have.property('hourly_rate');
Expand All @@ -184,7 +184,7 @@ describe('API', function() {
});
});
it('should be able to add new service', function(done) {
return mite.addService({
mite.addService({
name: 'Service'
}, function(err, service) {
service.service.should.have.property('billable');
Expand All @@ -199,7 +199,7 @@ describe('API', function() {
});
});
it('should be able to update service', function(done) {
return mite.updateService(1, {
mite.updateService(1, {
name: 'Service'
}, function(err, service) {
service.service.should.have.property('billable');
Expand All @@ -214,7 +214,7 @@ describe('API', function() {
});
});
return it('should be able to delete service', function(done) {
return mite.deleteService(1, function() {
mite.deleteService(1, function() {
return done();
});
});
Expand All @@ -228,7 +228,7 @@ describe('API', function() {
request: axiosMock
});
it('should be get all customers', function(done) {
return mite.getCustomers(function(err, customers) {
mite.getCustomers(function(err, customers) {
customers.should.have.length(1);
customers[0].customer.should.have.property('created_at');
customers[0].customer.should.have.property('hourly_rate');
Expand All @@ -243,7 +243,7 @@ describe('API', function() {
});
});
it('should be get all archived customers', function(done) {
return mite.getArchivedCustomers(function(err, customers) {
mite.getArchivedCustomers(function(err, customers) {
customers.should.have.length(1);
customers[0].customer.should.have.property('created_at');
customers[0].customer.should.have.property('hourly_rate');
Expand All @@ -258,7 +258,7 @@ describe('API', function() {
});
});
it('should be get one customer', function(done) {
return mite.getCustomer(1, function(err, customer) {
mite.getCustomer(1, function(err, customer) {
customer.customer.should.have.property('created_at');
customer.customer.should.have.property('hourly_rate');
customer.customer.should.have.property('id');
Expand All @@ -272,7 +272,7 @@ describe('API', function() {
});
});
it('should be able to add new customer', function(done) {
return mite.addCustomer({
mite.addCustomer({
name: 'Customer'
}, function(err, customer) {
customer.customer.should.have.property('created_at');
Expand All @@ -288,7 +288,7 @@ describe('API', function() {
});
});
it('should be able to update customer', function(done) {
return mite.updateCustomer(1, {
mite.updateCustomer(1, {
name: 'Customer'
}, function(err, customer) {
customer.customer.should.have.property('created_at');
Expand All @@ -304,7 +304,7 @@ describe('API', function() {
});
});
return it('should be able to delete customer', function(done) {
return mite.deleteCustomer(1, function() {
mite.deleteCustomer(1, function() {
return done();
});
});
Expand All @@ -318,7 +318,7 @@ describe('API', function() {
request: axiosMock
});
it('should be get all projects', function(done) {
return mite.getProjects(function(err, projects) {
mite.getProjects(function(err, projects) {
projects.should.have.length(1);
projects[0].project.should.have.property('budget');
projects[0].project.should.have.property('budget_type');
Expand All @@ -337,7 +337,7 @@ describe('API', function() {
});
});
it('should be get all archived projects', function(done) {
return mite.getArchivedProjects(function(err, projects) {
mite.getArchivedProjects(function(err, projects) {
projects.should.have.length(1);
projects[0].project.should.have.property('budget');
projects[0].project.should.have.property('budget_type');
Expand All @@ -356,7 +356,7 @@ describe('API', function() {
});
});
it('should be get one project', function(done) {
return mite.getProject(1, function(err, project) {
mite.getProject(1, function(err, project) {
project.project.should.have.property('budget');
project.project.should.have.property('budget_type');
project.project.should.have.property('created_at');
Expand All @@ -374,7 +374,7 @@ describe('API', function() {
});
});
it('should be able to add new project', function(done) {
return mite.addProject({
mite.addProject({
name: 'Project'
}, function(err, project) {
project.project.should.have.property('budget');
Expand All @@ -394,7 +394,7 @@ describe('API', function() {
});
});
it('should be able to update project', function(done) {
return mite.updateProject(1, {
mite.updateProject(1, {
name: 'Project'
}, function(err, project) {
project.project.should.have.property('budget');
Expand All @@ -414,7 +414,7 @@ describe('API', function() {
});
});
return it('should be able to delete project', function(done) {
return mite.deleteProject(1, function() {
mite.deleteProject(1, function() {
return done();
});
});
Expand All @@ -428,7 +428,7 @@ describe('API', function() {
request: axiosMock
});
it('should be get all users', function(done) {
return mite.getUsers(function(err, users) {
mite.getUsers(function(err, users) {
users.should.have.length(1);
users[0].user.should.have.property('created_at');
users[0].user.should.have.property('email');
Expand All @@ -443,7 +443,7 @@ describe('API', function() {
});
});
it('should be get all archived users', function(done) {
return mite.getArchivedUsers(function(err, users) {
mite.getArchivedUsers(function(err, users) {
users.should.have.length(1);
users[0].user.should.have.property('created_at');
users[0].user.should.have.property('email');
Expand All @@ -458,7 +458,7 @@ describe('API', function() {
});
});
it('should be get one user', function(done) {
return mite.getUser(1, function(err, user) {
mite.getUser(1, function(err, user) {
user.user.should.have.property('created_at');
user.user.should.have.property('email');
user.user.should.have.property('id');
Expand All @@ -472,7 +472,7 @@ describe('API', function() {
});
});
it('should be get myself', function(done) {
return mite.getMyself(function(err, user) {
mite.getMyself(function(err, user) {
user.user.should.have.property('created_at');
user.user.should.have.property('email');
user.user.should.have.property('id');
Expand All @@ -486,7 +486,7 @@ describe('API', function() {
});
});
return it('should be get the account', function(done) {
return mite.getAccount(function(err, account) {
mite.getAccount(function(err, account) {
account.account.should.have.property('created_at');
account.account.should.have.property('currency');
account.account.should.have.property('id');
Expand All @@ -506,7 +506,7 @@ describe('API', function() {
request: axiosMock
});
it('should be get all daily time entries', function(done) {
return mite.getDailyTimeEntries(2013, 1, 1, function(err, entries) {
mite.getDailyTimeEntries(2013, 1, 1, function(err, entries) {
entries.should.have.length(1);
entries[0].time_entry.should.have.property('billable');
entries[0].time_entry.should.have.property('created_at');
Expand All @@ -529,7 +529,7 @@ describe('API', function() {
});
});
it('should be get all time entries', function(done) {
return mite.getTimeEntries(function(err, entries) {
mite.getTimeEntries(function(err, entries) {
entries.should.have.length(1);
entries[0].time_entry.should.have.property('billable');
entries[0].time_entry.should.have.property('created_at');
Expand All @@ -552,7 +552,7 @@ describe('API', function() {
});
});
it('should be get one time entry', function(done) {
return mite.getTimeEntry(1, function(err, entry) {
mite.getTimeEntry(1, function(err, entry) {
entry.time_entry.should.have.property('billable');
entry.time_entry.should.have.property('created_at');
entry.time_entry.should.have.property('date_at');
Expand All @@ -574,7 +574,7 @@ describe('API', function() {
});
});
it('should be able to add new time entry', function(done) {
return mite.addTimeEntry({
mite.addTimeEntry({
name: 'TimeEntry'
}, function(err, entry) {
entry.time_entry.should.have.property('billable');
Expand All @@ -598,7 +598,7 @@ describe('API', function() {
});
});
it('should be able to update time entry', function(done) {
return mite.updateTimeEntry(1, {
mite.updateTimeEntry(1, {
name: 'TimeEntry'
}, function(err, entry) {
entry.time_entry.should.have.property('billable');
Expand All @@ -622,7 +622,7 @@ describe('API', function() {
});
});
return it('should be able to delete time entry', function(done) {
return mite.deleteTimeEntry(1, function() {
mite.deleteTimeEntry(1, function() {
return done();
});
});
Expand Down