Skip to content

fix(orm): return soft delete query results to be consistent with normal query operation results #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcj merged 1 commit into from
Sep 27, 2025
+4 −4
Merged

fix(orm): return soft delete query results to be consistent with normal query operation results #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/orm/src/plugin/soft-delete-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,21 @@ export class SoftDeleteQuery<T extends SoftDeleteEntity> extends Query<T> {
async restoreOne() {
const patch = { [deletedAtName]: undefined } as Partial<T>;
if (this.classSchema.hasProperty('deletedBy')) patch['deletedBy'] = undefined;
await this.withSoftDeleted().patchOne(patch);
return this.withSoftDeleted().patchOne(patch);
}

async restoreMany() {
const patch = { [deletedAtName]: undefined } as Partial<T>;
if (this.classSchema.hasProperty('deletedBy')) patch['deletedBy'] = undefined;
await this.withSoftDeleted().patchMany(patch);
return this.withSoftDeleted().patchMany(patch);
}

async hardDeleteOne() {
await this.withSoftDeleted().deleteOne();
return this.withSoftDeleted().deleteOne();
}

async hardDeleteMany() {
await this.withSoftDeleted().deleteMany();
return this.withSoftDeleted().deleteMany();
}
}

Expand Down