Skip to content

Conversation

@marcodejongh
Copy link
Owner

  • Fix duplicate climbs issue caused by COALESCE in LEFT JOIN creating
    cartesian product when playlistClimbs.angle is NULL (Aurora-synced)
  • Add new /playlists route at root level for simpler navigation
  • Add allUserPlaylists GraphQL query to fetch all playlists across boards
  • Add getDefaultBoardDetails helper for rendering playlists without
    full URL context
  • Support cross-layout playlist viewing with default board configurations

- Fix duplicate climbs issue caused by COALESCE in LEFT JOIN creating
  cartesian product when playlistClimbs.angle is NULL (Aurora-synced)
- Add new /playlists route at root level for simpler navigation
- Add allUserPlaylists GraphQL query to fetch all playlists across boards
- Add getDefaultBoardDetails helper for rendering playlists without
  full URL context
- Support cross-layout playlist viewing with default board configurations
@vercel
Copy link

vercel bot commented Jan 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
boardsesh Building Building Jan 2, 2026 0:09am

@claude
Copy link

claude bot commented Jan 2, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Issues

  1. Unused prop - packages/web/app/playlists/[playlist_uuid]/playlist-view-actions.tsx:10: boardDetails prop is declared but never used. Remove it from the type and component props.

  2. Hardcoded colors in CSS - The CSS files (playlist-view.module.css, playlists.module.css) use hardcoded color values like #F9FAFB, #111827, #6B7280 instead of design tokens from theme-config.ts. Per CLAUDE.md, design tokens should be used for colors. Consider using CSS variables or moving styles that need tokens to inline styles.

  3. Inline styles - packages/web/app/playlists/[playlist_uuid]/playlist-climbs-list.tsx:207-208: Uses inline style prop with hardcoded values (color: '#888', padding: '20px'). CLAUDE.md says to avoid the style property and use design tokens.

  4. Missing test coverage - No tests included for the new /playlists route, allUserPlaylists query, or the duplicate fix in the SQL join condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants