Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #281.
Problem:
Previously, useBuffer silently swallowed load errors (only console.error), and useModel had no way to surface them to the caller. This made it impossible to show error UI or recover gracefully when a model fails to load.
Changes:
Add UseBufferResult interface to useBuffer returning { buffer, error } instead of FilamentBuffer | undefined
Add error state to FilamentModel type
Propagate buffer load errors through useModel as { state: 'error', error }
Update all useBuffer call sites to destructure the new return shape
Testing:
Run the new ModelErrorHandling example in examples/Shared/src/ModelErrorHandling.tsx. It intentionally loads from an invalid URL — you should see the error message rendered instead of a blank screen.