Fix null warnings and clean up code in CheckedExceptions

[sibber5]

I didn't change any behavior or any implementation of anything, or any of the overall architecture, just some cleanup

[sibber5]

we could also add polysharp for polyfills for things like init properties

[sibber5]

or maybe bump the tfm to netstandard2.1?

[sibber5]

also you have inconsistent line endings, thats why there are some files that are diffed compeltely. you can copy those to like vscode to see the actual diffs edit: i ended up reusing the original line endings for a cleaner diff.

adding a .gitattributes will handle line endings repo wide, so that this doesnt happen again (see github docs).

[marinasundstrom]

Sorry for not seeing the PR sooner. I will have a look at it.

[sibber5]

all good. no pressure!

[sibber5]

@marinasundstrom are you intentionally casting to IMethodSymbol here or did you forget to remove this?

[marinasundstrom]

I think that is something left from earlier versions of that method. We certainly don't need it since we assign to a target of type ISymbol.

[sibber5]

var semanticModel = context.Compilation.GetSemanticModel(attrSyntax.SyntaxTree);

@marinasundstrom this gives a warning, see dotnet/roslyn-analyzers#3114:

GetSemanticModel is an expensive method to invoke within a diagnostic analyzer because it creates a completely new semantic model, which does not share compilation data with the compiler or other analyzers. This incurs an additional performance cost during semantic analysis. Instead, consider registering a different analyzer action which allows used of a shared SemanticModel, such as RegisterOperationAction, RegisterSyntaxNodeAction, or RegisterSemanticModelAction.

ctrl + shift + f shows this in 3 places, you might want to fix those

[marinasundstrom]

Thanks for pointing this out. I was honestly not thinking about it. And since I have had help from ChatGPT in many cases, I have just focused on making it work.

Yes, it should be passed down the call tree then.

[marinasundstrom]

Thanks! Great job.

I was thinking that some rules could be enforceable in .editorconfig. Make static fields readonly when possible. Like marking classes as sealed when not extended by others. Etc.