Skip to content

Clean special characters from rollup output file names#187

Merged
rturnq merged 5 commits into
mainfrom
copilot/update-rollup-output-options
Apr 7, 2026
Merged

Clean special characters from rollup output file names#187
rturnq merged 5 commits into
mainfrom
copilot/update-rollup-output-options

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 6, 2026

  • Understand the current cleanFileName and its callers
  • Update assetFileNames callback to fall back to _[hash].[ext] when name is falsey before or after clean
  • Update entryFileNames callback to fall back to _[hash].js when name is falsey before or after clean
  • Verify TypeScript compiles and ESLint passes
  • Run tests (2/2 passing)
  • Code review and security scan passed

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 6, 2026

CLA Not Signed

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 6, 2026

🦋 Changeset detected

Latest commit: a1226ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/run Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI requested a review from rturnq April 6, 2026 22:10
@rturnq rturnq marked this pull request as ready for review April 7, 2026 04:45
@rturnq
Copy link
Copy Markdown
Contributor

rturnq commented Apr 7, 2026

@copilot Add me as a co-author for all commits by appending the following to the commit messages:

Co-authored-by: rturnq <11449439+rturnq@users.noreply.github.com>

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 7, 2026

@copilot Add me as a co-author for all commits by appending the following to the commit messages:

Co-authored-by: rturnq <11449439+rturnq@users.noreply.github.com>

Added in e271c66. Note: I'm unable to force-push to rewrite the older commit messages, so only the latest commit has the co-author trailer. If this PR is squash-merged, the co-author will be included in the squash commit. If you need it on all individual commits, that would require a manual force push.

Copilot AI and others added 5 commits April 6, 2026 22:30
- Add cleanFileName helper to strip special chars from file names
- Update assetFileNames and entryFileNames rollup output options
- Add basic-assets-special-chars test fixture
- Add patch changeset

Co-authored-by: rturnq <11449439+rturnq@users.noreply.github.com>
Agent-Logs-Url: https://github.com/marko-js/run/sessions/eb8bd937-3055-470c-8070-7cba119a6bc4
@rturnq rturnq force-pushed the copilot/update-rollup-output-options branch from e271c66 to a1226ed Compare April 7, 2026 05:31
@rturnq
Copy link
Copy Markdown
Contributor

rturnq commented Apr 7, 2026

/easycla

@rturnq rturnq merged commit 0ad5aef into main Apr 7, 2026
14 of 17 checks passed
@rturnq rturnq deleted the copilot/update-rollup-output-options branch April 7, 2026 18:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (aba9493) to head (a1226ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #187   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants