Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR experiments with replacing Biome-based lint/format tooling with the Oxc toolchain (oxlint + oxfmt), and updates CI and code formatting to match the new tooling output.
Changes:
- Replace Biome with
oxlint/oxfmtin npm scripts and add corresponding config files. - Update GitHub Actions workflow to run separate format + lint steps (and adjust YAML formatting).
- Apply mechanical formatting changes across TS/TSX/HTML/Markdown and update translation source references accordingly.
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/translations/en.po | Update source line references after formatting changes. |
| src/translations/fr.po | Update source line references after formatting changes. |
| src/translations/es.po | Update source line references after formatting changes. |
| src/translations/ja.po | Update source line references after formatting changes. |
| src/translations/ru.po | Update source line references after formatting changes. |
| src/translations/zh-CN.po | Update source line references after formatting changes. |
| src/translations/zh-TW.po | Update source line references after formatting changes. |
| src/routes/settings.library.tsx | Adjust hook dependency array formatting to satisfy new linting expectations. |
| src/hooks/useGlobalTrackListStatus.ts | Adjust effect dependency array (library API object vs method reference). |
| src/components/TrackList.tsx | Formatting refactors and dependency array adjustments (no functional intent). |
| src/components/DropzoneImport.tsx | Simplify effect dependencies to depend on API objects. |
| src/tests/test-helpers.tsx | Switch to vi.doMock for mocks declared inside beforeEach. |
| src-tauri/Cargo.toml | Mechanical formatting/indentation changes. |
| package.json | Swap Biome scripts/deps for oxlint/oxfmt; update trusted dependencies and metadata ordering. |
| package-lock.json | Remove Biome packages; add oxlint/oxfmt and their dependency trees. |
| index.html | HTML formatting changes (doctype casing, self-closing tags). |
| README.md | Normalize formatting/line endings. |
| .oxlintrc.json | Add oxlint configuration (plugins + ignores). |
| .oxfmtrc.json | Add oxfmt configuration (print width, quotes, ignores). |
| .github/workflows/build.yml | Run format and lint separately; adjust YAML formatting/matrix layout. |
Comments suppressed due to low confidence (1)
package.json:84
oxfmt/oxlintpackages in the lockfile require Node^20.19.0 || >=22.12.0, butpackage.jsondoesn’t declare anengines.nodeconstraint. Adding an explicit Node engine (and/or an.nvmrc) would prevent confusing install failures for contributors on older Node versions.
"lightningcss": "1.31.1",
"oxfmt": "0.33.0",
"oxlint": "1.48.0",
"playwright": "1.58.2",
"simple-git-hooks": "2.13.1",
"typescript": "5.9.3",
"typescript-plugin-css-modules": "5.2.0",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if I'll move forward with this, I'm just playing with it. There are things I like, things I don't.
Overall, Biome opinions feel nicer, everything make sense. On the other hand,
oxcmay have momentum (as it come from the creators ofvite), so better integration with vitest, etc.