Adds support for passing through hosted zone prefix and suffix#61
Open
mscottford wants to merge 1 commit intomassdriver-cloud:mainfrom
Open
Adds support for passing through hosted zone prefix and suffix#61mscottford wants to merge 1 commit intomassdriver-cloud:mainfrom
mscottford wants to merge 1 commit intomassdriver-cloud:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows specifying values for the
edns--txt-prefixand--txt-suffixparameters. The default value for--txt-prefixis set toedns.to avoid collisions with any non-A records that may already exist in the hosted zone for the specified domain name.TODO: Once massdriver-cloud/terraform-modules#198 is merged, then the
sourceused for theexternal_dnsmodule needs to be updated to reference a git sha that includes the merged pull request. This should not be merged in before that happens, because doing so will cause errors.Depends on massdriver-cloud/terraform-modules#198
Fixes #55.