Bugfix for transformations on Arcs #238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading an SVG with rounded rectangles and transforms, the
Pathtransform function gave the following error when transforming some of theArcpaths:After digging into it, some rotations generated eigenvectors with complex values rather than real values.
The fix was to use the Hermitian form (
np.linalg.eigh) instead ofnp.linalg.eigfor the eigenvector/value computations which is guaranteed to return reals. As far as I can tell, this is valid based on how theDmatrix is generated asinvT * Q * T.The following SVG is (close to) a minimal reproducer:
I added a test to
ArcTestthat triggers the error before the bugfix and is resolved by the bugfix.