Skip to content

📱 Fix header menu & directory filter responsive#41

Open
marchalleo wants to merge 2 commits into
mathieutu:mainfrom
marchalleo-mba2:fix-responsive
Open

📱 Fix header menu & directory filter responsive#41
marchalleo wants to merge 2 commits into
mathieutu:mainfrom
marchalleo-mba2:fix-responsive

Conversation

@marchalleo
Copy link
Copy Markdown
Contributor

  • Menu burger position (before/after) :
Capture d’écran 2024-02-22 à 15 45 52 Capture d’écran 2024-02-22 à 15 46 28
  • Directory filter category (before/after) :
Capture d’écran 2024-02-22 à 15 46 51 Capture d’écran 2024-02-22 à 15 47 15
  • Directory filter searchBar (before/after) :
Capture d’écran 2024-02-22 à 15 47 50 Capture d’écran 2024-02-22 à 15 48 03

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 22, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @mathieutu on Vercel.

@mathieutu first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
resap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 3:13pm

Copy link
Copy Markdown
Owner

@mathieutu mathieutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your help!

You changed a lot the style of the code, which make your changes more difficult to review. Could you revert them and focus only on your changes?

@marchalleo
Copy link
Copy Markdown
Contributor Author

Indeed, sorry!

I simplified with a new commit for better understanding.

Copy link
Copy Markdown
Owner

@mathieutu mathieutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let you check the code diff. There are still a lot of unneeded changes, and the linter is failing. (your last commit didn't revert your changes)

@mathieutu mathieutu force-pushed the main branch 3 times, most recently from cfe28ca to b35f67a Compare June 19, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants