Add Nextcloud 33 compatibility#124
Open
bakiburakogun wants to merge 4 commits into
Open
Conversation
added 2 commits
April 8, 2026 15:15
- Bump max-version from 32 to 33 in info.xml - Replace deprecated QueryBuilder::execute() with executeStatement() for DELETE queries (NoteShareMapper, TagMapper) - removed in NC33 - Add explicit type hints to all constructor parameters to fix PHP 8.4 implicitly nullable parameter deprecation (, , ) - Replace deprecated script()/style() template helpers with \OCP\Util::addScript()/addStyle() - Remove unsupported 'length' parameter from integer/bigint columns in migration files (Doctrine DBAL 3.x+ compatibility) - Improve user sharing: increase perPage from 50 to 200 and add dynamic search-as-you-type via sharees API so all users are discoverable Tested on Nextcloud 33.0.2 with PHP 8.4
- Replace hardcoded colors (#202124, #808080, #15c, #fff, #000) with NC CSS variables (--color-main-text, --color-box-shadow, --color-primary-element, --color-main-background, etc.) - Fix removed --color-primary-light → --color-primary-element-light - Fix color picker background for dark mode - Fix medium editor toolbar: all colors now use CSS variables with fallbacks for backward compatibility - Fix note badges (.slim-share, .slim-tag) hover states - Fix icon header button hover states All changes use var(--name, fallback) syntax for backward compatibility with older Nextcloud versions.
bakiburakogun
force-pushed
the
nc33-compatibility
branch
3 times, most recently
from
855ca0c to
15978f4
Compare
added 2 commits
April 8, 2026 18:10
- Add pagination support to _loadUsersSharing via _loadUsersSharingPage - Increase perPage to 200 and use OCS v2 API endpoint - Add formatInputTooShort prompt in share dialog - Fix 'height:' property name typo (trailing colon)
NC33 sets position:fixed on #content, creating a stacking context that traps .modal-note-background (position:fixed, z-index:9998) below #header (z-index:2000 in root stacking context). Additionally, #app-content is a flex item with z-index:1000, which per CSS spec creates its own stacking context even without explicit position. Fix: Use CSS :has() selector to conditionally: - Change #content from position:fixed to position:relative (removes stacking context, lets modal escape to root context) - Set #app-content z-index to auto (removes flex-item stacking context) - Set overflow:visible on #content (removes overflow:clip) Also update .modal-note-background z-index from 1051 to 9998 to match NC33's NcModal .modal-mask, and simplify overlay background. Closes matiasdelellis#123
bakiburakogun
force-pushed
the
nc33-compatibility
branch
from
15978f4 to
0e30927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #123 — Adds full Nextcloud 33.0.x + PHP 8.4 compatibility.
Changes (16 files)
Breaking Fixes
appinfo/info.xmlmax-version="32"blocks NC3333lib/Db/NoteShareMapper.phpQueryBuilder::execute()removed in NC33executeStatement()lib/Db/TagMapper.phpQueryBuilder::execute()removed in NC33executeStatement()templates/main.phpscript()/style()deprecated\OCP\Util::addScript/addStylePHP 8.4 Type Safety
lib/Controller/NoteApiController.phpstring $AppName,?string $userId,?string $colorlib/Controller/NoteController.phpstring $AppName,?string $userId,?string $colorlib/Controller/AttachmentApiController.phpstring $AppName,?string $userIdlib/Controller/SettingsController.phpstring $appName,?string $userIdlib/Controller/ShareController.phpstring $AppName,?string $userIdlib/Controller/PageController.phpstring $appNamelib/Service/FileService.php?string $userIdlib/Service/NoteService.php?string $colorMigration Fixes (Doctrine DBAL 3.x)
lib/Migration/Version000204Date20200530211356.php'length'from bigint/integer columnslib/Migration/Version000301Date20200613151711.php'length'from bigint/integer columnsUser Sharing Improvements
js/script.jsperPage: 50→200, addedsearchUsersSharing()for dynamic AJAX searchjs/qn-dialogs.jstagsmode withquerymode (search-as-you-type via sharees API)Testing
Tested on Nextcloud 33.0.2 with PHP 8.4: