Adds code to show scope in the list view, #PG-5113#23
Merged
Conversation
lachiebol
requested changes
Apr 20, 2026
Contributor
lachiebol
left a comment
lachiebol
left a comment
There was a problem hiding this comment.
Functionally looks good just a few nitpicks/questions
AltamashShaikh
commented
Apr 21, 2026
| $field->title = Piwik::translate('OAuth2_SystemSettingOAuthEnableRefreshTokenTitle'); | ||
| }); | ||
|
|
||
| $scopes = ScopeRepository::getScopeDescriptions(); |
Contributor
Author
There was a problem hiding this comment.
This was the cause of fatal error on activation, the required vendor libraries are not loaded by this time.
lachiebol
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds code to show scope in the list view
Issue No
#PG-5113
Steps to Replicate the Issue
Checklist