Skip to content

Fixes various QA identified issues, #PG-5091#31

Merged
AltamashShaikh merged 2 commits into
5.x-devfrom
PG-5091-fix-qa-issue
May 8, 2026
Merged

Fixes various QA identified issues, #PG-5091#31
AltamashShaikh merged 2 commits into
5.x-devfrom
PG-5091-fix-qa-issue

Conversation

@AltamashShaikh
Copy link
Copy Markdown
Contributor

Description

Fixes various QA identified issues

  1. Non-numerical values are not allowed in the settings
  2. Fixing invalid URLs like URL\tURL
  3. Client secret message, should now contain the client secret too.

Issue No

#PG-5091

Steps to Replicate the Issue

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [✔] Are all newly added texts included via translation?
  • [✔] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

@AltamashShaikh AltamashShaikh added the Needs Review For pull requests that need a code review. label May 7, 2026
@AltamashShaikh AltamashShaikh requested a review from lachiebol May 7, 2026 07:06
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an unused translation, rest LGTM

Comment thread OAuth2.php Outdated
@AltamashShaikh AltamashShaikh requested a review from lachiebol May 8, 2026 02:50
@AltamashShaikh AltamashShaikh merged commit 093ed39 into 5.x-dev May 8, 2026
9 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-5091-fix-qa-issue branch May 8, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants