Skip to content

Adds code to log warning and add new activity on auth approve/deny, #AS-542#32

Merged
AltamashShaikh merged 3 commits into
5.x-devfrom
AS-542
May 14, 2026
Merged

Adds code to log warning and add new activity on auth approve/deny, #AS-542#32
AltamashShaikh merged 3 commits into
5.x-devfrom
AS-542

Conversation

@AltamashShaikh
Copy link
Copy Markdown
Contributor

Description

Adds code to log warning and add new activity on auth approve/deny

Issue No

#AS-542

Steps to Replicate the Issue

  1. Should add activities for auth screen
image
  1. adds warning logs - Requested by Thomas
  2. updates the isRevoked method to check for client status

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [✖] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [✖] Documentation updated?

@AltamashShaikh AltamashShaikh added the Needs Review For pull requests that need a code review. label May 12, 2026
@AltamashShaikh AltamashShaikh requested a review from lachiebol May 12, 2026 01:42
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one question

Comment thread Controller.php
@AltamashShaikh AltamashShaikh merged commit d1f19ba into 5.x-dev May 14, 2026
9 checks passed
@AltamashShaikh AltamashShaikh deleted the AS-542 branch May 14, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review For pull requests that need a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants