Skip to content

Disable character range check for user IDs#410

Merged
S7evinK merged 3 commits intomatrix-org:mainfrom
neilalexander:neil/historicallyvalid
Dec 10, 2025
Merged

Disable character range check for user IDs#410
S7evinK merged 3 commits intomatrix-org:mainfrom
neilalexander:neil/historicallyvalid

Conversation

@neilalexander
Copy link
Copy Markdown
Contributor

This check is not safe in existing room versions because Synapse hasn't enforced it properly either.

Related: matrix-org/matrix-spec#1506, matrix-org/matrix-spec-proposals#2828

Signed-off-by: Neil Alexander git@neilalexander.dev

This check is not safe because Synapse hasn't enforced it properly either.

Signed-off-by: Neil Alexander <git@neilalexander.dev>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 15, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.11%. Comparing base (eb14008) to head (a076af0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
+ Coverage   54.07%   54.11%   +0.03%     
==========================================
  Files          52       52              
  Lines        5993     5993              
==========================================
+ Hits         3241     3243       +2     
+ Misses       2342     2341       -1     
+ Partials      410      409       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neilalexander
Copy link
Copy Markdown
Contributor Author

cc @S7evinK @devonh

Copy link
Copy Markdown
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the hill I'm dying on.

matrix-org/matrix-spec#1506 (comment)

If the above clarification PR lands, then I'll admit defeat and merge this.

@bones-was-here
Copy link
Copy Markdown

Bump: that did get merged :/

@neilalexander neilalexander requested a review from kegsay August 15, 2025 11:33
Copy link
Copy Markdown
Collaborator

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the spec clarification.. merged.. sadly..

// Edit: Please don't hunt me down for this @kegsay

@S7evinK S7evinK merged commit ffcbbd3 into matrix-org:main Dec 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants