feat: add CreatorInCreateEvent to help with default room v11#465
Merged
kegsay merged 3 commits intomatrix-org:mainfrom May 6, 2026
Merged
feat: add CreatorInCreateEvent to help with default room v11#465kegsay merged 3 commits intomatrix-org:mainfrom
kegsay merged 3 commits intomatrix-org:mainfrom
Conversation
Signed-off-by: Thomas Traineau t.traineau@famedly.com
FrenchGithubUser
force-pushed
the
tt/CreatorInCreateEvent
branch
from
e6d5627 to
52795b0
Compare
Signed-off-by: Thomas Traineau t.traineau@famedly.com
reivilibre
requested changes
Apr 28, 2026
Contributor
reivilibre
left a comment
reivilibre
left a comment
There was a problem hiding this comment.
I guess I don't understand what this is (maybe the comments can be a bit more enlightening, it probably needs too much context from the spec changes over the years)
| checkKnockingAllowedFunc: disallowKnocking, | ||
| checkRestrictedJoinAllowedFunc: disallowRestrictedJoins, | ||
| checkCreateEvent: checkCreateEventV1, | ||
| creatorInCreateEvent: true, |
Contributor
There was a problem hiding this comment.
I think most of these should be false, if I understand it right?
Contributor
Author
There was a problem hiding this comment.
this is false from room v11 and above
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 53.94% 53.88% -0.07%
==========================================
Files 52 52
Lines 6021 6028 +7
==========================================
Hits 3248 3248
- Misses 2359 2366 +7
Partials 414 414 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
sorry about the missing comments. Let me know if there are further questions |
kegsay
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to matrix-org/complement#858
Pull Request Checklist
Signed-off-by:
Thomas Traineau <t.traineau@famedly.com>