Handle DCL vendor info timeouts during startup#1375
Open
ivaschru wants to merge 1 commit intomatter-js:mainfrom
Open
Handle DCL vendor info timeouts during startup#1375ivaschru wants to merge 1 commit intomatter-js:mainfrom
ivaschru wants to merge 1 commit intomatter-js:mainfrom
Conversation
Author
|
I validated this patch on the affected HAOS 17.2 / amd64 installation by building a temporary local add-on from the official Result from the live add-on startup: And the listener is open afterwards: So the patch fixes the startup blocker at the vendor-info DCL step: the server now reaches the WebSocket bind even when the DCL vendor endpoint times out. One adjacent observation: on a fresh storage path, the earlier PAA DCL fetch can also hang until aiohttp's default ~5 minute timeout before falling back to Git. That is separate from this PR, but likely worth a follow-up timeout improvement for startup latency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeoutErrorthe same way asClientErrorso vendor catalog refresh remains best-effort.Why
In
MatterServer.start(),vendor_info.start()runs beforemount_websocket()andMultiHostTCPSite.start(). If the DCL vendor endpoint stalls until aiohttp raisesTimeoutError, that exception is currently not handled and the Matter Server never reaches the WebSocket bind step. Supervisor can still report the add-on service as started, butcore-matter-server:5580/wskeeps returning connection refused.This matches the startup failure being tracked in
home-assistant/addons#4560.Tests