bump memory limit to ensure Mautic in dev mode can handle it#301
Merged
escopecz merged 1 commit intomautic:mainfrom Apr 19, 2023
Merged
bump memory limit to ensure Mautic in dev mode can handle it#301escopecz merged 1 commit intomautic:mainfrom
escopecz merged 1 commit intomautic:mainfrom
Conversation
Contributor
Author
|
@escopecz both the tests for this PR as the manual run (this branch + mautic/mautic#12213) succeed |
escopecz
approved these changes
Apr 19, 2023
Member
escopecz
left a comment
escopecz
left a comment
There was a problem hiding this comment.
Makes sense. Thanks Mattias!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see mautic/mautic#12213 (comment)
this is most likely related tot the default
memory_limitof 128M, which is not enough for the standard apache install.This PR is a mitigation: the proper solution I'm working on is in #290
I also pushed this PR, so we can test it against the Symfony 5 PR, see the workflow: https://github.com/mautic/api-library/actions/runs/4740330977
both the workflow from this PR as the extra workflow should succeed before merging this